Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only copy PG cert to server when postgresql_use_ssl #37

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Only copy PG cert to server when postgresql_use_ssl #37

merged 2 commits into from
Jan 5, 2024

Conversation

p-j-smith
Copy link
Contributor

Currently the XNAT role always attempts to copy to PG cert from the cache:

ansible-collection-infra/roles/xnat/tasks/main.yml

Lines 13 to 19 in b5385d7

- name: Get postgres server certificate from cache
ansible.builtin.copy:
src: "{{ database_server_certificate_cache_filename }}"
dest: "{{ postgresql_client.server_certificate_filename }}"
owner: "{{ postgresql_client_ssl_certificate.owner }}"
group: "{{ postgresql_client_ssl_certificate.group }}"
mode: "0600"

This should only be done if postgresql_use_ssl is true

@p-j-smith p-j-smith requested a review from a team January 5, 2024 16:07
paddyroddy
paddyroddy previously approved these changes Jan 5, 2024
View reviewed changes
@paddyroddy paddyroddy requested a review from a team January 5, 2024 16:38
@paddyroddy paddyroddy merged commit 9807009 into main Jan 5, 2024
3 checks passed
@paddyroddy paddyroddy deleted the fix/xnat-postgresql branch January 5, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paddyroddy paddyroddy paddyroddy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p-j-smith @paddyroddy